-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add missing comma in sources list #16613
Conversation
I wonder how it was building / working so far with this issue! |
Triggering another CI to double check Windows failure: https://ci.nodejs.org/job/node-test-pull-request/11125/ |
4688584
to
3ca202f
Compare
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h
test/arm-fanned failure looks unrelatedwarning: failed to remove out/
Removing out/
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Did not find any matching files. Setting build result to FAILURE.
Checking ^not ok
Jenkins Text Finder: File set '*.tap' is empty
Notifying upstream projects of job completion
Finished: FAILURE test/windows-fanned failure looks unrelatedResetting working tree
> git reset --hard # timeout=10
> git clean -fdx # timeout=10
[node-test-binary-windows] $ cmd /c call C:\Users\ADMINI~1\AppData\Local\Temp\1\jenkins4777955810906737101.bat
c:\workspace\node-test-binary-windows>echo off
Wed 11/01/2017 4:03:40.35
c:\workspace\node-test-binary-windows>tasklist | grep node || true
c:\workspace\node-test-binary-windows>exit 0
[node-test-binary-windows] $ cmd /c call C:\Users\ADMINI~1\AppData\Local\Temp\1\jenkins2702603836202563709.bat
c:\workspace\node-test-binary-windows>TASKKILL /F /IM node.exe /T || TRUE
ERROR: The process "node.exe" not found.
c:\workspace\node-test-binary-windows>TASKKILL /F /IM cctest.exe /T || TRUE
ERROR: The process "cctest.exe" not found.
c:\workspace\node-test-binary-windows>TASKKILL /F /IM run-tests.exe /T || TRUE
ERROR: The process "run-tests.exe" not found.
c:\workspace\node-test-binary-windows>TASKKILL /F /IM yes.exe /T || TRUE
ERROR: The process "yes.exe" not found.
c:\workspace\node-test-binary-windows>git checkout -f refs/remotes/jenkins_tmp/jenkins-node-test-commit-windows-fanned-13053-binary-windows/win-vs2013
error: pathspec 'refs/remotes/jenkins_tmp/jenkins-node-test-commit-windows-fanned-13053-binary-windows/win-vs2013' did not match any file(s) known to git.
c:\workspace\node-test-binary-windows>if 1 NEQ 0 exit /b 1
Build step 'Execute Windows batch command' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Did not find any matching files. Setting build result to FAILURE.
Checking ^not ok
Jenkins Text Finder: File set '*.tap' is empty
Notifying upstream projects of job completion
Finished: FAILURE |
Landed in 18df171 |
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h PR-URL: #16613 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h PR-URL: nodejs/node#16613 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h PR-URL: nodejs#16613 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Since these are |
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h PR-URL: #16613 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h PR-URL: nodejs/node#16613 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
build