Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: revert #3384 DEP0019 EOL #16634

Closed
wants to merge 1 commit into from

Commits on Oct 31, 2017

  1. module: revert nodejs#3384 DEP0019 EOL

    The original commit was landed without running CITGM. Unfortunately
    this change breaks the module `d` which has over 500k downloads a day.
    
    It is worth mentioning that the compatibility hack can be removed
    without breaking anything.
    
    We should definitely revisit for the next Semver-Major but shipping
    this today will cause non trivial ecosystem breakages.
    
    Refs: nodejs#3384
    MylesBorins committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    6bad984 View commit details
    Browse the repository at this point in the history