Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix etw provider include on Windows #16639

Closed
wants to merge 1 commit into from
Closed

src: fix etw provider include on Windows #16639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/node_win32_etw_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

#include "node_win32_etw_provider.h"
Copy link
Member Author

@joyeecheung joyeecheung Oct 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oddly, this does not work if I put node_win32_etw_provider.h behind node_etw_provider.h, but node_etw_provider.h is generated with a manifest and from what I can tell it only contains a bunch of constants, so should be self-contained..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which reminds me if the self-contain-ness can't be fixed properly then I will have to turn clang-format off here in #16122 ...

#include "node_etw_provider.h"
#include "node_win32_etw_provider-inl.h"

Expand Down