Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: auto fix custom eslint rule for crypto-check.js #16647

Closed
wants to merge 7 commits into from
Closed

tools: auto fix custom eslint rule for crypto-check.js #16647

wants to merge 7 commits into from

Commits on Feb 12, 2018

  1. tools: auto fix custom eslint rule for crypto-check.js 

    1. Fixer for crypto-check.js
2. extends tests

Refs : nodejs#16636
    @shobhitchittora
    shobhitchittora committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    b35d423 View commit details
    Browse the repository at this point in the history

  2. tools: auto fix custom eslint rule for crypto-check.js 

    Removes unwanted indentation

Refs : nodejs#16636
    @shobhitchittora
    shobhitchittora committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    803357b View commit details
    Browse the repository at this point in the history

  3. tools: auto fix custom eslint rule for crypto-check.js 

    Adds check for fixing on when require('common') is present.

Refs : nodejs#16636
    @shobhitchittora
    shobhitchittora committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    6d6cdc6 View commit details
    Browse the repository at this point in the history

  4. tools: auto fix custom eslint rule for crypto-check.js 

    Adds "missing crypto" message in tests.

Refs : nodejs#16636
    @shobhitchittora
    shobhitchittora committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    1f52446 View commit details
    Browse the repository at this point in the history

  5. tools: auto fix custom eslint rule for crypto-check.js 

    1. Refactors test
2. Removes commonModule AST node as array.

Refs : nodejs#16636
    @shobhitchittora
    shobhitchittora committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    2ecf517 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. tools: auto fix custom eslint rule for crypto-check.js 

    Review comments + updates test cases

Refs : nodejs#16636
    @shobhitchittora
    shobhitchittora committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    1018b5b View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2018

  1. tools: auto fix custom eslint rule for crypto-check.js 

    Removes extra spaces ( lint-error ) + rules-utils argument check
suggestoin

Refs : nodejs#16636
    @shobhitchittora
    shobhitchittora committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    46206b7 View commit details
    Browse the repository at this point in the history