http: use 'connect' event only if socket is connecting #16725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug that prevented `ClientRequest.prototype.setTimeout()` from working properly when the socket was reused for multiple requests. Fixes: nodejs#16716 Refs: nodejs#8895
|
@nodejs/collaborators can you please take a look? It would be nice to have this fix in the next 9.x release. |
Trott
approved these changes
Nov 6, 2017
jasnell
approved these changes
Nov 6, 2017
cjihrig
approved these changes
Nov 6, 2017
benjamingr
approved these changes
Nov 6, 2017
|
Landed in f60c692. |
lpinca
added a commit
that referenced
this pull request
Nov 6, 2017
Fixes a bug that prevented `ClientRequest.prototype.setTimeout()` from working properly when the socket was reused for multiple requests. Fixes: #16716 Refs: #8895 PR-URL: #16725 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
Fixes a bug that prevented `ClientRequest.prototype.setTimeout()` from working properly when the socket was reused for multiple requests. Fixes: nodejs#16716 Refs: nodejs#8895 PR-URL: nodejs#16725 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Nov 7, 2017
Notable changes:
* CLI:
- NODE_OPTIONS now supports the --stack-trace-limit option.
nodejs#16495
* deps:
- OpenSSL is upgraded to 1.0.2m
nodejs#16691
* http:
- A 'connect' event handler leak has been fixed.
nodejs#16725
- The 103 Early Hints status code is now supported.
nodejs#16644
PR-URL: nodejs#16851
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that prevented
ClientRequest.prototype.setTimeout()fromworking properly when the socket was reused for multiple requests.
Fixes: #16716
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http