Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: replace string concatenation with template literals #16804

Closed
wants to merge 1 commit into from
Closed

tools: replace string concatenation with template literals #16804

wants to merge 1 commit into from

Conversation

kevinwcyu
Copy link
Contributor

Replace string concatenation in tools/doc/preprocess.js with template literals.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • tools

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Nov 6, 2017
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
gireeshpunathil
gireeshpunathil reviewed Nov 6, 2017
View reviewed changes
tools/doc/preprocess.js Outdated
inc + `\n<!-- [end-include:${fname}] -->\n`;
input = input.split(include + '\n').join(includeData[fname] + '\n');
includeData[fname] = `<!-- [start-include:${fname}] -->
${inc}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lost indentation here?

apapirovski
apapirovski reviewed Nov 6, 2017
View reviewed changes
tools/doc/preprocess.js Outdated
includeData[fname] = `<!-- [start-include:${fname}] -->\n` +
inc + `\n<!-- [end-include:${fname}] -->\n`;
input = input.split(include + '\n').join(includeData[fname] + '\n');
includeData[fname] = `<!-- [start-include:${fname}] -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-line string concatenation is actually ok (the way it was before), but it would be nice if the 2nd line became this instead:

`${inc}\n<!-- [end-include:${fname}] -->\n`

That way we don't have to lose indentation level.

@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11230/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 6, 2017
@kevinwcyu @Trott
tools: replace string concatenation with template literals
13e983b 
Replace string concatenation with template literals in
tools/doc/preprocess.js.

PR-URL: nodejs#16804
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@Trott
Copy link
Member

Trott commented Nov 6, 2017

Landed in 13e983b

@Trott Trott closed this Nov 6, 2017
@Trott
Copy link
Member

Trott commented Nov 6, 2017

Thanks for the contribution! 🎉

cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
@kevinwcyu @cjihrig
tools: replace string concatenation with template literals
6e22dc8 
Replace string concatenation with template literals in
tools/doc/preprocess.js.

PR-URL: nodejs#16804
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@cjihrig cjihrig mentioned this pull request Nov 7, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@kevinwcyu @MylesBorins
tools: replace string concatenation with template literals
79b8096 
Replace string concatenation with template literals in
tools/doc/preprocess.js.

PR-URL: #16804
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@kevinwcyu @MylesBorins
tools: replace string concatenation with template literals
60c918a 
Replace string concatenation with template literals in
tools/doc/preprocess.js.

PR-URL: #16804
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@kevinwcyu @MylesBorins
tools: replace string concatenation with template literals
adc43a7 
Replace string concatenation with template literals in
tools/doc/preprocess.js.

PR-URL: #16804
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@kevinwcyu @MylesBorins
tools: replace string concatenation with template literals
1c192f5 
Replace string concatenation with template literals in
tools/doc/preprocess.js.

PR-URL: #16804
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil left review comments

@apapirovski apapirovski apapirovski approved these changes

@Trott Trott Trott approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kevinwcyu @vsemozhetbyt @Trott @apapirovski @gireeshpunathil @MylesBorins @nodejs-github-bot