Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: make eslint work on subdirectories #1686

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

The old pattern didn't include files in lib/internal. This changes the pattern to directories which makes eslint apply to all subdirectories as well.

related: #1685

cc: @yosuke-furukawa

@chrisdickinson
Copy link
Contributor

This is included in my repl PR as well.

@silverwind
Copy link
Contributor Author

@chrisdickinson yep, please manually lint it until this is landed.

@chrisdickinson
Copy link
Contributor

@silverwind Ah, I mean, these changes are literally included in my PR :)

@chrisdickinson
Copy link
Contributor

I can rebase once this lands, though. LGTM.

silverwind added a commit that referenced this pull request May 12, 2015
The old pattern didn't include files in lib/internal. This changes the
pattern to directories which makes eslint apply to all subdirectories as
well.

PR-URL: #1686
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
@silverwind
Copy link
Contributor Author

Thanks, landed in c58264e

@silverwind silverwind closed this May 12, 2015
@yosuke-furukawa
Copy link
Member

AH, Thanks @silverwind !

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 19, 2015
The old pattern didn't include files in lib/internal. This changes the
pattern to directories which makes eslint apply to all subdirectories as
well.

PR-URL: nodejs#1686
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants