Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update tools/icu/README.md #16939

Closed
wants to merge 0 commits into from
Closed

doc: Update tools/icu/README.md #16939

wants to merge 0 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Nov 10, 2017 •
edited
Loading

  • remove TODOs: the one about defaults has been
    addressed, and the one about testing is a work
    item that doesn't belong in a doc.
  • add some background information

Fixes: #7843

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Nov 10, 2017
@srl295 srl295 self-assigned this Nov 10, 2017
@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory. labels Nov 10, 2017
mathiasbynens
mathiasbynens reviewed Nov 12, 2017
View reviewed changes
tools/icu/README.md Outdated
# Notes about the icu directory.
# Notes about the `tools/icu` subdirectory

This directory contains tools, data, and information about the [http://icu-project.org](ICU) (International Components for Unicode) integration. ICU is used to provide Intl functionality.
Copy link
Contributor

@mathiasbynens mathiasbynens Nov 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: not just Intl.* — it‘s also used for e.g. RegExp Unicode property escapes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathiasbynens Would just using internationalization functionality instead of Intl functionality sound good to you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that sounds good!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(dramatic pause) 👍

mhdawson
mhdawson approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/10/

I would like to land this soon so will implement the change suggested by @mathiasbynens myself. It's been sitting around for almost a month now due to that tiny little thing.

@BridgeAR
Copy link
Member

New Mini-CI (seemed like the old one failed?): https://ci.nodejs.org/job/node-test-commit-light/148/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 19, 2018
srl295 added a commit that referenced this pull request Jan 30, 2018
@srl295
doc: Update tools/icu/README.md
07712d1 
- remove TODOs: the one about defaults has been
addressed, and the one about testing is a work
item that doesn't belong in a doc.
- add some background information

Fixes: #7843

PR-URL: #16939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@srl295 srl295 closed this Jan 30, 2018
@srl295 srl295 deleted the update-icu-guide branch January 30, 2018 00:35
@apapirovski apapirovski mentioned this pull request Jan 30, 2018
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
@srl295 @MylesBorins
doc: Update tools/icu/README.md
f86f6a7 
- remove TODOs: the one about defaults has been
addressed, and the one about testing is a work
item that doesn't belong in a doc.
- add some background information

Fixes: #7843

PR-URL: #16939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@srl295 @MylesBorins
doc: Update tools/icu/README.md
8ce2368 
- remove TODOs: the one about defaults has been
addressed, and the one about testing is a work
item that doesn't belong in a doc.
- add some background information

Fixes: #7843

PR-URL: #16939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@srl295 @MylesBorins
doc: Update tools/icu/README.md
2d968ca 
- remove TODOs: the one about defaults has been
addressed, and the one about testing is a work
item that doesn't belong in a doc.
- add some background information

Fixes: #7843

PR-URL: #16939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
@MylesBorins
Copy link
Contributor

Does this need to be backported?

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@srl295 @MayaLekova
doc: Update tools/icu/README.md