Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove superfluous check in backtrace_posix.cc #16950

Closed
wants to merge 1 commit into from
Closed

src: remove superfluous check in backtrace_posix.cc #16950

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

The error check doesn't matter because a failure would be ignored as part of the loop condition.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@addaleax
src: remove superfluous check in backtrace_posix.cc
0836e11 
The error check doesn't matter because a failure would be ignored
as part of the loop condition.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 11, 2017
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/14022/

This should be ready.

@addaleax
Copy link
Member Author

Landed in 8854598

@addaleax addaleax closed this Nov 18, 2017
@addaleax addaleax deleted the backtrace-superfluous-line branch November 18, 2017 19:58
addaleax added a commit that referenced this pull request Nov 18, 2017
@addaleax
src: remove superfluous check in backtrace_posix.cc
8854598 
The error check doesn't matter because a failure would be ignored
as part of the loop condition.

PR-URL: #16950
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@addaleax @MylesBorins
src: remove superfluous check in backtrace_posix.cc
4387a73 
The error check doesn't matter because a failure would be ignored
as part of the loop condition.

PR-URL: #16950
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@MylesBorins
Copy link
Contributor

@addaleax should this be backported to v6.x or v8.x?

@MylesBorins
Copy link
Contributor

ping @addaleax

@MylesBorins
Copy link
Contributor

ping @addaleax

MylesBorins pushed a commit that referenced this pull request May 22, 2018
@addaleax @MylesBorins
src: remove superfluous check in backtrace_posix.cc
bdbef5f 
The error check doesn't matter because a failure would be ignored
as part of the loop condition.

PR-URL: #16950
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@addaleax @MylesBorins
src: remove superfluous check in backtrace_posix.cc
d694bea 
The error check doesn't matter because a failure would be ignored
as part of the loop condition.

PR-URL: #16950
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@addaleax @rvagg
src: remove superfluous check in backtrace_posix.cc
7cf26e5 
The error check doesn't matter because a failure would be ignored
as part of the loop condition.

PR-URL: #16950
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
@kissofire kissofire mentioned this pull request Mar 7, 2021
Open
@meghasfdc meghasfdc mentioned this pull request Mar 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @MylesBorins @refack @jasnell @targos @cjihrig @gireeshpunathil @nodejs-github-bot