Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix compiler warning in process.ppid #16958

Closed
wants to merge 1 commit into from
Closed

src: fix compiler warning in process.ppid #16958

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 12, 2017

This commit fixes a compiler warning with SetAccessor() by passing in the context.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@cjihrig
src: fix compiler warning in process.ppid
f990824 
This commit fixes a compiler warning with SetAccessor() by
passing in the context.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 12, 2017
@addaleax addaleax mentioned this pull request Nov 12, 2017
Closed
2 tasks
@TimothyGu
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11381/

@TimothyGu TimothyGu mentioned this pull request Nov 14, 2017
Closed
2 tasks
@fhinkel
Copy link
Member

fhinkel commented Nov 14, 2017

Thanks. Landed in 2b93151.

@fhinkel fhinkel closed this Nov 14, 2017
fhinkel pushed a commit that referenced this pull request Nov 14, 2017
@cjihrig @fhinkel
src: fix compiler warning in process.ppid
2b93151 
This commit fixes a compiler warning with SetAccessor() by
passing in the context.

PR-URL: #16958
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
evanlucas pushed a commit that referenced this pull request Nov 14, 2017
@cjihrig @evanlucas
src: fix compiler warning in process.ppid
bdec4d9 
This commit fixes a compiler warning with SetAccessor() by
passing in the context.

PR-URL: #16958
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@cjihrig cjihrig deleted the warning branch November 14, 2017 21:31
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging or v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@hashseed hashseed mentioned this pull request Jan 4, 2018
Merged
BethGriggs pushed a commit to BethGriggs/node that referenced this pull request Jul 11, 2018
@cjihrig @BethGriggs
src: fix compiler warning in process.ppid
8ac3c67 
This commit fixes a compiler warning with SetAccessor() by
passing in the context.

PR-URL: nodejs#16958
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Jul 11, 2018
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Jul 13, 2018
@cjihrig @MylesBorins
src: fix compiler warning in process.ppid
c7b1976 
This commit fixes a compiler warning with SetAccessor() by
passing in the context.

Backport-PR-URL: #21760
PR-URL: #16958
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@cjihrig @rvagg
src: fix compiler warning in process.ppid
6f545d1 
This commit fixes a compiler warning with SetAccessor() by
passing in the context.

Backport-PR-URL: #21760
PR-URL: #16958
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
@kissofire kissofire mentioned this pull request Mar 7, 2021
Open
@meghasfdc meghasfdc mentioned this pull request Mar 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cjihrig @TimothyGu @fhinkel @MylesBorins @danbev @jasnell @addaleax @gireeshpunathil @nodejs-github-bot