Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate bench #16977

Closed
wants to merge 1 commit into from
Closed

remove duplicate bench #16977

wants to merge 1 commit into from

Conversation

ivancsicsmarkus
Copy link

Just removed duplicate bench.

#16968

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v9.x labels Nov 12, 2017
jasnell
jasnell previously approved these changes Nov 12, 2017
View reviewed changes
mscdex
mscdex suggested changes Nov 12, 2017
View reviewed changes
Copy link
Contributor

@mscdex mscdex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should target the master branch instead of the versioned branch.

cjihrig
cjihrig approved these changes Nov 12, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if retargeted at master.

@refack refack changed the base branch from v9.x to master November 13, 2017 11:02
@refack refack changed the base branch from master to v9.x November 13, 2017 11:03
@jasnell jasnell changed the base branch from v9.x to master November 13, 2017 20:35
@jasnell
Copy link
Member

jasnell commented Nov 13, 2017

Retargeted the PR to master, definitely needs a rebase.

@jasnell jasnell dismissed their stale review November 13, 2017 20:36

Needs rebase against master

@apapirovski
Copy link
Member

apapirovski commented Nov 14, 2017 •
edited
Loading

I think this might need to be closed. It doesn't look like the original PR branch & repository exist anymore?

@jasnell jasnell closed this Nov 14, 2017
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
@kissofire kissofire mentioned this pull request Mar 7, 2021
Open
@meghasfdc meghasfdc mentioned this pull request Mar 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex requested changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell left review comments

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ivancsicsmarkus @jasnell @apapirovski @mscdex @cjihrig @nodejs-github-bot