doc: recommend against use of node_path #1708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Sometimes deployments that rely on `NODE_PATH` show surprising behavior | ||
| when people are unaware that `NODE_PATH` must be set. Sometimes a | ||
| module's dependencies change, causing a different version (or even a | ||
| different module) to be loaded as the `NODE_PATH` is searched. |
There was a problem hiding this comment.
We go on in the document to suggest using NODE_PATH to make global modules require-able in the REPL – we should probably nix that.
I'd also suggest bolding the line below, "You are highly encouraged to place your dependencies locally in node_modules folders."
There was a problem hiding this comment.
I'd move this disclaimer about global modules to the top of this section, possibly bolding it.
|
LGTM |
silverwind
pushed a commit
that referenced
this pull request
May 17, 2015
PR-URL: #1708 Reviewed-By: Roman Reiss <me@silverwind.io>
|
landed in 7d90c90 |
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
PR-URL: nodejs/node#1708 Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1627