Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v6.x backport] src: remove unused includes from node_wrap.h #17092

Closed
wants to merge 1 commit into from
Closed

[v6.x backport] src: remove unused includes from node_wrap.h #17092

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Nov 17, 2017

I cannot find any usages of these includes and think they can be
removed.

Refs: #16179

PR-URL: #16179
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: remove unused includes from node_wrap.h
bb9df3e 
I cannot find any usages of these includes and think they can be
removed.

PR-URL: nodejs#16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v6.x labels Nov 17, 2017
@danbev
Copy link
Contributor Author

danbev commented Nov 17, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11495/

@MylesBorins
Copy link
Contributor

Looks like CI failed, running one more time for posterity

https://ci.nodejs.org/job/node-test-pull-request/11711/

@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 28, 2017 •
edited
Loading

Landed in e67a377

MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@danbev @MylesBorins
src: remove unused includes from node_wrap.h
e67a377 
I cannot find any usages of these includes and think they can be
removed.

Backport-PR-URL: #17092
PR-URL: #16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@danbev @MylesBorins
src: remove unused includes from node_wrap.h
ae3ad55 
I cannot find any usages of these includes and think they can be
removed.

Backport-PR-URL: #17092
PR-URL: #16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev danbev deleted the backport-16179-to-v6.x branch March 27, 2018 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@maclover7 maclover7 maclover7 approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danbev @MylesBorins @maclover7 @gireeshpunathil @nodejs-github-bot