-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: better error message on python fail #17298
Conversation
I suggest this as an alternative to #17293 |
31ff552
to
6a10eb5
Compare
/CC @nodejs/build @nodejs/platform-windows |
This still has the issues I mentioned in #17015 (comment). Namely:
|
(2) bug fixed, and made the "validation" section explicit. What I suggest is that we are gaining more then we're losing. Using |
@@ -172,8 +181,6 @@ if "%target%"=="Clean" echo deleting %~dp0deps\icu | |||
if "%target%"=="Clean" rmdir /S /Q %~dp0deps\icu | |||
:no-depsicu | |||
|
|||
call :getnodeversion || exit /b 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next line uses FULLVERSION
which is populated in getnodeversion
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by making the rmdir line more generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%TAG% is used in project-gen
too.
I'll continue working on refactoring the MSI & release bits to a separate batch file, that way we can wrap python, and other dependency resolution in a consistent way, and handle that section differently since is not used by occasional builders. |
46ec09d
to
aa15c27
Compare
@@ -354,6 +363,7 @@ if not defined msi goto run | |||
|
|||
:msibuild | |||
echo Building node-v%FULLVERSION%-%target_arch%.msi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't %FULLVERSION%
set by getnodeversion
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also in :package
Ping @refack |
Closing due to long inactivity. @refack please feel free to reopen if you would like to continue working on this! |
Fixes: #16864
Refs: #17293
On a machine without python installed:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
build,windows,tools