Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance crypto/sig.js coverage #17426

Closed
wants to merge 9 commits into from
Closed

Enhance crypto/sig.js coverage #17426

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
93bbd52
test: add test call crypt.Sign without new
Leko Dec 2, 2017
fddf884
test: add test call crypt.Verify without new
Leko Dec 2, 2017
e6a004e
test: add test padding is undefined
Leko Dec 2, 2017
dbfb965
test: add test saltLength is undefined
Leko Dec 2, 2017
355029e
test: add missing semi coron
Leko Dec 2, 2017
dabbdf9
test: Fix typo sign -> verify
Leko Dec 2, 2017
0b80e14
test: add expected behavior to assertion error message
Leko Dec 2, 2017
fc3ffc9
test: use + to break strings and fix indent
Leko Dec 2, 2017
2d8ea1a
test: Use assert instead of assert.ok
Leko Dec 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions test/parallel/test-crypto-sign-verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,42 @@ const certPem = fixtures.readSync('test_cert.pem', 'ascii');
const keyPem = fixtures.readSync('test_key.pem', 'ascii');
const modSize = 1024;

{
const Sign = crypto.Sign;
const instance = Sign('SHA256');
assert.ok(instance instanceof Sign, 'Sign is expected to return a new \
instance when called without `new` keyword');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, two more things:

  1. assert instead of assert.ok
  2. We usually try to break strings using + and line them up beneath each other, so something like this:
assert(instance instanceof Sign, 'Sign is expected to return a new instance ' +
                                 'when called without `new` keyword');

Same below. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind.

assert instead of assert.ok

What difference between assert.ok and assert ?
I think assert() is better because there are fewer characters, right ?

Copy link
Member

@apapirovski apapirovski Dec 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert.ok is just an alias for assert (or, well, the other way around...). Not better but I think in general we try to use assert.

The practical difference in this case is it lets us fit that first line instead of having to split everything significantly more awkwardly. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your detailed information.
I understood that assert was better.

}

{
const Verify = crypto.Verify;
const instance = Verify('SHA256');
assert.ok(instance instanceof Verify, 'Verify is expected to return a new \
instance when called without `new` keyword');
}

common.expectsError(
() => crypto.createVerify('SHA256').verify({
key: certPem,
padding: undefined,
}, ''),
{
code: 'ERR_INVALID_OPT_VALUE',
type: Error,
message: 'The value "undefined" is invalid for option "padding"'
});

common.expectsError(
() => crypto.createVerify('SHA256').verify({
key: certPem,
saltLength: undefined,
}, ''),
{
code: 'ERR_INVALID_OPT_VALUE',
type: Error,
message: 'The value "undefined" is invalid for option "saltLength"'
});

// Test signing and verifying
{
const s1 = crypto.createSign('SHA1')
Expand Down