debugger: improve clearBreakpoint error and docs #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R=@bajtos? @julianduque Can you wrap the documentation at 80 columns? Thanks. |
|
@bnoordhuis doc fixed |
| var scripts = this.client.scripts; | ||
| var keys = Object.keys(scripts); | ||
| for (var v = 0; v < keys.length; v++) { | ||
| var id = keys[v]; |
There was a problem hiding this comment.
L1476-L1478 can be IMO simplified to for (var id in scripts).
|
Quite a lot of extra complexity needed to print a correct message, but I suppose the UX gain is worth it. The code looks correct to me, I did not run it myself though. |
|
@bajtos fixed doc and simplified code with your suggestions |
Currently clearBreakpoint error is confusing, it says Script not found when there is no breakpoint, also documentation doesn't include signature for clearBreakpoint
|
@bnoordhuis AFAICT, this patch can be landed. |
|
Cheers, waiting for the CI to finish. |
bnoordhuis
pushed a commit
that referenced
this pull request
Dec 19, 2014
Currently clearBreakpoint error is confusing, it says "Script not found" when there is no breakpoint, also documentation doesn't include signature for clearBreakpoint. PR-URL: #175 Reviewed-By: Miroslav Bajtoš <miroslav@strongloop.com>
|
CI looks healthy. Thanks both of you, landed in c4a308d. |
kunalspathak
referenced
this pull request
in nodejs/node-chakracore
Jan 22, 2016
If `--debug` is specified, the in-built 'Debug' object is exposed by chakra.dll that has some [APIs](https://msdn.microsoft.com/en-us/library/bs12a9wf(v=vs.94).aspx) that node-uwp relies on. With my change in #155, I had overriden 'Debug' global object and hence certain Debug APIs stopped working with `--debug` switch. The original intent of adding `Debug` object was that `util.js` fetches this object in Debugging context. In absense of `--debug` flag this object is unavailable and hence `util.js` throws TypeError. The fix is to expose `Debug` object only in the DebugContext (called from `util.js`). If ran with `--debug`, by the time `utill.js` code executes, engine would have already expose in-built `Debug` object and we won't overwrite it. Without `--debug` we would override `Debug` object. Thanks @agarwal-sandeep for helping debugging this issue. Fixes : #175
boingoing
pushed a commit
to boingoing/node
that referenced
this pull request
Apr 6, 2017
This was referenced Jul 20, 2020
This was referenced Dec 1, 2020
This was referenced May 26, 2021
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
May 28, 2024
syg
pushed a commit
to syg/node
that referenced
this pull request
Jun 20, 2024
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently clearBreakpoint error is confusing, it says script not found when there is no breakpoint, also
documentation doesn't include signature for clearBreakpoint.