Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in Buffer.prototype.fill() #17501

Merged
merged 1 commit into from
Dec 6, 2017
Merged

doc: fix typo in Buffer.prototype.fill() #17501

merged 1 commit into from
Dec 6, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 6, 2017

Refs: #17427 (comment)
R= @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Dec 6, 2017
Trott
Trott approved these changes Dec 6, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly no need to wait the full 48 hours on this. :-D

@cjihrig
doc: fix typo in Buffer.prototype.fill()
70f23ec 
Refs: nodejs#17427
PR-URL: nodejs#17501
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig merged commit 70f23ec into nodejs:master Dec 6, 2017
@cjihrig cjihrig deleted the docs branch December 6, 2017 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @Trott @lpinca @MylesBorins @nodejs-github-bot