Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding Countdown to test-http-set-cookies test #17504

Closed
wants to merge 4 commits into from
Closed

test: adding Countdown to test-http-set-cookies test #17504

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ef1c59
adding Countdown to test-http-set-cookies test
shilomagen Dec 6, 2017
f855134
adding Countdown to test-http-set-cookies test
shilomagen Dec 6, 2017
2676d7c
adding Countdown to test-http-set-cookies test
shilomagen Dec 6, 2017
39f8099
adding Countdown to test-http-set-cookies test
shilomagen Dec 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions test/parallel/test-http-set-cookies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
require('../common');
const common = require('../common');
const assert = require('assert');
const http = require('http');
const Countdown = require('../common/countdown');

let nresponses = 0;

const countdown = new Countdown(2, common.mustCall(() => server.close()));
Copy link
Contributor

@apapirovski apapirovski Dec 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't strictly need the common.mustCall but it's not a deal breaker. (If you do remove it, you'll need to also remove the const common = part above (but keep the actual require).

const server = http.createServer(function(req, res) {
if (req.url === '/one') {
res.writeHead(200, [['set-cookie', 'A'],
Expand Down Expand Up @@ -55,9 +55,7 @@ server.on('listening', function() {
});

res.on('end', function() {
if (++nresponses === 2) {
server.close();
}
countdown.dec();
});
});

Expand All @@ -72,14 +70,9 @@ server.on('listening', function() {
});

res.on('end', function() {
if (++nresponses === 2) {
server.close();
}
countdown.dec();
});
});

});

process.on('exit', function() {
assert.strictEqual(2, nresponses);
});