Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] async_wrap: add provider types for net server #17623

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] async_wrap: add provider types for net server #17623

wants to merge 1 commit into from

Conversation

AndreasMadsen
Copy link
Member

Original PR: #17157

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

async_wrap

@AndreasMadsen
async_wrap: add provider types for net server
67ca4d7 
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Dec 11, 2017
@AndreasMadsen AndreasMadsen mentioned this pull request Dec 11, 2017
Closed
4 tasks
@AndreasMadsen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12048/

@AndreasMadsen AndreasMadsen removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 11, 2017
@AndreasMadsen AndreasMadsen changed the title [v8.x backport] async_wrap: add provider types for net server #17621 [v8.x backport] async_wrap: add provider types for net server Dec 13, 2017
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@AndreasMadsen @gibfahn
async_wrap: add provider types for net server
8fd61e1 
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.

PR-URL: #17157
Backport-PR-URL: #17623
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn
Copy link
Member

gibfahn commented Dec 19, 2017

Thanks @AndreasMadsen, landed in 8fd61e1

@gibfahn gibfahn closed this Dec 19, 2017
@gibfahn gibfahn reopened this Dec 20, 2017
@gibfahn
Copy link
Member

gibfahn commented Dec 20, 2017

My mistake, this is semver-minor, it'll have to wait till the next minor release.

@gibfahn gibfahn added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 20, 2017
@AndreasMadsen
Copy link
Member Author

This is now included in #18179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreasMadsen @gibfahn @nodejs-github-bot