doc: instructions on how to make membership public #17688

mhdawson · 2017-12-14T20:25:09Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc

maclover7

One small comment, otherwise LGTM.

maclover7 · 2017-12-14T20:33:33Z

doc/onboarding.md

@@ -38,6 +38,10 @@ onboarding session.
      * Branches in the nodejs/node repository are only for release lines
    * [See "Updating Node.js from Upstream"](./onboarding-extras.md#updating-nodejs-from-upstream)
    * Make a new branch for each PR you submit.
+    * Membership: We ask that collaborators make their membership in the Node.js


Maybe specify GitHub membership or move into a separate GitHub section? At first is a little bit unclear.

Just to clarify, is this a request or a requirement for collaborators?

Maybe move to near the requirement for enabling 2FA?

I agree, the current wording makes this sound like a requirement, which is something I would be really careful about.

@cjihrig

Just to clarify, is this a request or a requirement for collaborators?

Having your membership public means GitHub can assign you the appropriate UI badges. As it is now...

...there's no indicator that you're part of the Node org. much less a member of the TSC or collaborator.

Your membership is already public in the sense that your name is listed here and here. This just lets GitHub do their UI thing so that users can more easily identify project maintainers.

I know. Aren't the labels that GitHub shows next to your name in these threads, along with the list in the project's README enough?

I'm fine with a request/recommendation, but would be -1 on a hard requirement.

I'm saying as it is now your label is incorrect. I'm also labeled a "contributor" but I'm not part of the org (not a collaborator, TSC, or core). The "contributor" badge just means I've had at least 1 commit merged. If you were part of the org you would have the label "member" or "owner".

Ah, I thought you were a contributor :-)

Even still, I'm not sure that it would be a huge help. We have a members team with over 500 people that includes more people than the core collaborator list.

I'm mostly being argumentative on principle. It feels like Node would be overstepping its boundaries by requiring that collaborators make membership public. I'm a member of several other orgs, and none of them have such a requirement.

Ah, I thought you were a contributor :-)

Exactly. You proved my point 😋

The closeness of "collaborator" and "contributor" may also be part of the confusion.

@cjihrig the "Owner" next to your name is only shown if the current logged-in user is in the @ nodejs org. If I wasn't logged in, I would see "Contributor" instead.

Trott · 2017-12-14T23:07:36Z

I updated the text a bit (capitalized Collaborators the way we do everywhere else, made it clear this is a request, etc.). PTAL. It's a separate commit so it can be reverted if it's TERRIBLE.

addaleax

The current wording sounds fine to me :)

maclover7 · 2017-12-21T01:29:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/35/

maclover7 · 2017-12-21T14:42:46Z

Landing...

maclover7 · 2017-12-21T14:45:16Z

Landed in 7a0f774

PR-URL: nodejs#17688 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #17688 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

doc: instructions on how to make membership public

a0da3b8

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 14, 2017

mhdawson mentioned this pull request Dec 14, 2017

More clear indicator of key stakeholders and gatekeepers of features. nodejs/TSC#442

Closed

lpinca approved these changes Dec 14, 2017

View reviewed changes

maclover7 approved these changes Dec 14, 2017

View reviewed changes

jasnell approved these changes Dec 14, 2017

View reviewed changes

Update onboarding.md

3dddd0b

addaleax approved these changes Dec 14, 2017

View reviewed changes

TimothyGu approved these changes Dec 14, 2017

View reviewed changes

cjihrig approved these changes Dec 14, 2017

View reviewed changes

gireeshpunathil approved these changes Dec 15, 2017

View reviewed changes

maclover7 approved these changes Dec 15, 2017

View reviewed changes

BridgeAR approved these changes Dec 21, 2017

View reviewed changes

maclover7 self-assigned this Dec 21, 2017

maclover7 closed this Dec 21, 2017

MylesBorins mentioned this pull request Jan 10, 2018

v9.4.0 proposal #18069

Merged

gibfahn added land-on-v6.x labels Jan 24, 2018

MylesBorins mentioned this pull request Jan 24, 2018

v6.13.0 proposal #18342

Merged

mhdawson deleted the membership-organization branch September 30, 2019 13:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: instructions on how to make membership public #17688

doc: instructions on how to make membership public #17688

mhdawson commented Dec 14, 2017

maclover7 left a comment

maclover7 Dec 14, 2017

cjihrig Dec 14, 2017

richardlau Dec 14, 2017

addaleax Dec 14, 2017

jdalton Dec 14, 2017 •

edited

Loading

cjihrig Dec 14, 2017

jdalton Dec 14, 2017 •

edited

Loading

cjihrig Dec 14, 2017

jdalton Dec 14, 2017 •

edited

Loading

TimothyGu Dec 14, 2017 •

edited

Loading

Trott commented Dec 14, 2017

addaleax left a comment

maclover7 commented Dec 21, 2017

maclover7 commented Dec 21, 2017

maclover7 commented Dec 21, 2017

doc: instructions on how to make membership public #17688

doc: instructions on how to make membership public #17688

Conversation

mhdawson commented Dec 14, 2017

Checklist

Affected core subsystem(s)

maclover7 left a comment

Choose a reason for hiding this comment

maclover7 Dec 14, 2017

Choose a reason for hiding this comment

cjihrig Dec 14, 2017

Choose a reason for hiding this comment

richardlau Dec 14, 2017

Choose a reason for hiding this comment

addaleax Dec 14, 2017

Choose a reason for hiding this comment

jdalton Dec 14, 2017 • edited Loading

Choose a reason for hiding this comment

cjihrig Dec 14, 2017

Choose a reason for hiding this comment

jdalton Dec 14, 2017 • edited Loading

Choose a reason for hiding this comment

cjihrig Dec 14, 2017

Choose a reason for hiding this comment

jdalton Dec 14, 2017 • edited Loading

Choose a reason for hiding this comment

TimothyGu Dec 14, 2017 • edited Loading

Choose a reason for hiding this comment

Trott commented Dec 14, 2017

addaleax left a comment

Choose a reason for hiding this comment

maclover7 commented Dec 21, 2017

maclover7 commented Dec 21, 2017

maclover7 commented Dec 21, 2017

jdalton Dec 14, 2017 •

edited

Loading

jdalton Dec 14, 2017 •

edited

Loading

jdalton Dec 14, 2017 •

edited

Loading

TimothyGu Dec 14, 2017 •

edited

Loading