Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused async hooks methods #17757

Closed
wants to merge 1 commit into from
Closed

src: remove unused async hooks methods #17757

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 19, 2017
@addaleax addaleax added the async_hooks Issues and PRs related to the async hooks subsystem. label Dec 19, 2017
maclover7
maclover7 approved these changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is OK

@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/12209/

@addaleax
Copy link
Member Author

Landed in 482c27e

@addaleax addaleax closed this Dec 20, 2017
@addaleax addaleax deleted the async-unused branch December 20, 2017 06:06
addaleax added a commit that referenced this pull request Dec 20, 2017
@addaleax
src: remove unused async hooks methods
482c27e 
PR-URL: #17757
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: vdeturckheim <vlad2t@hotmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@addaleax @MylesBorins
src: remove unused async hooks methods
d93c57a 
PR-URL: #17757
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: vdeturckheim <vlad2t@hotmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@addaleax @MylesBorins
src: remove unused async hooks methods
99c62cc 
PR-URL: #17757
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: vdeturckheim <vlad2t@hotmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
@AndreasMadsen AndreasMadsen mentioned this pull request Jan 16, 2018
Closed
4 tasks
gibfahn pushed a commit to gibfahn/node that referenced this pull request Jan 17, 2018
@addaleax @gibfahn
src: remove unused async hooks methods
8e8d0b3 
PR-URL: nodejs#17757
Backport-PR-URL: nodejs#18179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: vdeturckheim <vlad2t@hotmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2018
@addaleax @MylesBorins
src: remove unused async hooks methods
089f18e 
Backport-PR-URL: #18179
PR-URL: #17757
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: vdeturckheim <vlad2t@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@vdeturckheim vdeturckheim vdeturckheim approved these changes

@hiroppy hiroppy hiroppy approved these changes

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.