Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update AUTHORS list #1776

Merged
merged 1 commit into from
May 23, 2015
Merged

doc: update AUTHORS list #1776

merged 1 commit into from
May 23, 2015

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented May 23, 2015

Update AUTHORS list using tools/update-authors.sh

@smikes and @thefourtheye you are going in as:

thefourtheye <thechargingvolcano@gmail.com>
smikes <smikes@cubane.com>

Can I put in a proper name for either of you or is this preferred?

@rvagg
Copy link
Member Author

rvagg commented May 23, 2015

@yosuke-furukawa note you are going in as your gmail address even though your git email has changed, which do you prefer (see .mailmap diff on this PR)?

@thefourtheye
Copy link
Contributor

@rvagg Can you include my actual name as well? Maybe like Sakthipriyan Vairamani - thefourtheye?

@rvagg
Copy link
Member Author

rvagg commented May 23, 2015

@thefourtheye we don't really have a convention of including github handles here, it's mainly just a list of names @ email addresses that are pulled from your git config (i.e. the git log). Would you mind if I made it just Sakthipriyan Vairamani? See the existing AUTHORS file for how everyone else is displayed.

@smikes
Copy link
Contributor

smikes commented May 23, 2015

Sam Mikes smikes@cubane.com

Thanks!

On Fri, May 22, 2015 at 7:22 PM, Rod Vagg notifications@github.com
wrote:

@thefourtheye we don't really have a convention of including github handles here, it's mainly just a list of names @ email addresses that are pulled from your git config (i.e. the git log). Would you mind if I made it just Sakthipriyan Vairamani? See the existing AUTHORS file for how everyone else is displayed.

Reply to this email directly or view it on GitHub:
#1776 (comment)

@mscdex mscdex added the doc Issues and PRs related to the documentations. label May 23, 2015
@rvagg
Copy link
Member Author

rvagg commented May 23, 2015

the entries now come up as

Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sam Mikes <smikes@cubane.com>

See the .mailmap attached to this PR for what was done to make that happen.

Will wait for feedback from @thefourtheye before proceeding.

@thefourtheye
Copy link
Contributor

we don't really have a convention of including github handles here, it's mainly just a list of names @ email addresses that are pulled from your git config (i.e. the git log)

@raff Cool, that should be fine 😊 I ll update my git config so that my next PRs will not have this problem. Thanks for checking with me 😊

@bnoordhuis
Copy link
Member

LGTM

@yosuke-furukawa
Copy link
Member

@rvagg My email is yosuke.furukawa@gmail.com .

@rvagg
doc: update AUTHORS list
367ffd1 
Update AUTHORS list using tools/update-authors.sh

PR-URL: nodejs#1776
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg merged commit 367ffd1 into nodejs:master May 23, 2015
@rvagg rvagg deleted the update-authors branch May 23, 2015 22:17
@rvagg
Copy link
Member Author

rvagg commented May 23, 2015

367ffd1

@rvagg rvagg mentioned this pull request May 23, 2015
Closed
andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this pull request Jun 3, 2015
@rvagg @andrewdeandrade
doc: update AUTHORS list
72fefc1 
Update AUTHORS list using tools/update-authors.sh

PR-URL: nodejs/node#1776
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rvagg @thefourtheye @smikes @bnoordhuis @yosuke-furukawa @mscdex