Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-http-pipeline-flood #17955

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-http-pipeline-flood #17955

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

@apapirovski apapirovski commented Jan 2, 2018 •
edited
Loading

This fixes one of the issues with this test (the repeated timeout, for which there's no real reason to validate that it only occurs exactly once). Haven't been able to reproduce the other one so perhaps there was a bug that was fixed in the meantime or something. Not sure.

Refs: #16317

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@apapirovski apapirovski added the test Issues and PRs related to the tests. label Jan 2, 2018
@apapirovski
Copy link
Member Author

apapirovski commented Jan 2, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/12391/
Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/1603/

@apapirovski apapirovski force-pushed the fix-test-http-pipeline-flood branch 2 times, most recently from 888a02f to a41fba7 Compare January 3, 2018 02:23
@apapirovski apapirovski force-pushed the fix-test-http-pipeline-flood branch from a41fba7 to 0ea2754 Compare January 3, 2018 02:44
@apapirovski apapirovski added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 3, 2018
@apapirovski
Copy link
Member Author

ping @nodejs/http @nodejs/http2 — this test fails fairly regularly so it would be nice to get it fixed. The timeout here is irrelevant to the test and is only used to stop it so having it called multiple times is completely harmless.

@apapirovski
Copy link
Member Author

Landed in b396c4d

@apapirovski apapirovski closed this Jan 6, 2018
@apapirovski apapirovski deleted the fix-test-http-pipeline-flood branch January 6, 2018 17:48
apapirovski added a commit that referenced this pull request Jan 6, 2018
@apapirovski
test: fix flaky test-http-pipeline-flood
b396c4d 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
7711f00 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
7feabf5 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
b313e81 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
@TimothyGu TimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2018
@BridgeAR BridgeAR mentioned this pull request Jan 15, 2018
Closed
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
edcf9ac 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
a275032 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
5c40881 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
dffe0e1 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
4473c6c 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apapirovski @jasnell @MylesBorins @TimothyGu