Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change assert message to default #18259

Closed
wants to merge 2 commits into from
Closed

test: change assert message to default #18259

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45a938a
test: change assert message to default
ryanmahan Jan 19, 2018
7d6a2f6
Corrections for PR comments
ryanmahan Jan 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/known_issues/test-http-path-contains-unicode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ const http = require('http');

const expected = '/café🐶';

//Sanity check for café🐶 is café🐶
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is actually not even necessary. It will be printed in case of a error and the expected value is visible as well.

assert.strictEqual(
expected,
'/caf\u{e9}\u{1f436}',
'Sanity check that string literal produced the expected string'
'/caf\u{e9}\u{1f436}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please swap the arguments (actual first expected second) and put everything on the same line now that it doesn't take more than 80 chars? Thank you.

);

const server = http.createServer(common.mustCall(function(req, res) {
Expand Down