Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make linters independent of local node #18272

Closed
wants to merge 2 commits into from
Closed

build: make linters independent of local node #18272

wants to merge 2 commits into from

Conversation

joyeecheung
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 20, 2018
@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 20, 2018 •
edited
Loading

cc @nodejs/build

CI: https://ci.nodejs.org/job/node-test-pull-request/12644/

New one: https://ci.nodejs.org/job/node-test-pull-request/12665/

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 22, 2018
@joyeecheung
Copy link
Member Author

Landed in 6a56a0a...13bc53f, thanks!

@joyeecheung joyeecheung removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 23, 2018
joyeecheung added a commit that referenced this pull request Jan 23, 2018
@joyeecheung
build: make lint-md independent of local node
be0778b 
PR-URL: #18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Jan 23, 2018
@joyeecheung
build: make lint-js independent of local node
13bc53f 
PR-URL: #18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@joyeecheung @evanlucas
build: make lint-md independent of local node
ce1eb0b 
PR-URL: #18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@joyeecheung @evanlucas
build: make lint-js independent of local node
2a9afc4 
PR-URL: #18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging or v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

This was referenced Apr 7, 2024
Open
Open
This was referenced Apr 7, 2024
Open
Open
Open
Open
Open
This was referenced Apr 7, 2024
Open
Open
Open
Open
Open
@baby636 baby636 mentioned this pull request Apr 7, 2024
Open
@ryan-ally ryan-ally mentioned this pull request Apr 7, 2024
Open
This was referenced Apr 7, 2024
Open
Open
Open
Open
Open
@aliscco aliscco mentioned this pull request Apr 7, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Apr 7, 2024
Open
This was referenced Apr 8, 2024
Open
Open
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 9, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Oct 9, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Oct 11, 2024
Open
This was referenced Oct 21, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyeecheung @MylesBorins @jasnell @gibfahn @nodejs-github-bot