Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix e.g., to e.g. in docs #18369

Closed
wants to merge 1 commit into from
Closed

doc: fix e.g., to e.g. in docs #18369

wants to merge 1 commit into from

Conversation

sreepurnajasti
Copy link
Contributor

Fixes: nodejs/code-and-learn#58

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 25, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 25, 2018
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/127/

@vsemozhetbyt
Copy link
Contributor

Landed in c016cc2

vsemozhetbyt pushed a commit that referenced this pull request Jan 25, 2018
@sreepurnajasti @vsemozhetbyt
doc: fix e.g., to e.g. in docs
c016cc2 
PR-URL: #18369
Fixes: nodejs/code-and-learn#58
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott
Copy link
Member

Trott commented Jan 25, 2018

Whoa, that was fast. Um, I would have objected to this. The comma is correct in American usage which is what we follow in our docs. See, e.g., https://www.dailywritingtips.com/comma-after-i-e-and-e-g/.

@vsemozhetbyt
Copy link
Contributor

@Trott Sorry. Should I make a PR to revert it?

@Trott
Copy link
Member

Trott commented Jan 25, 2018

@Trott Sorry. Should I make a PR to revert it?

I'd probably prefer a PR that changes e.g. to for example because there seems to be little benefit to abbreviating it and I suspect a lot of people don't actually know what e.g. means. :-D

@sreepurnajasti
Copy link
Contributor Author

@Trott Agreed. I would like to take this up!! :)

@sreepurnajasti sreepurnajasti deleted the my-branch2 branch January 26, 2018 06:38
@sreepurnajasti sreepurnajasti mentioned this pull request Jan 26, 2018
Closed
2 tasks
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@sreepurnajasti @evanlucas
doc: fix e.g., to e.g. in docs
6ae7bb1 
PR-URL: #18369
Fixes: nodejs/code-and-learn#58
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@sreepurnajasti @MylesBorins
doc: fix e.g., to e.g. in docs
504054c 
PR-URL: #18369
Fixes: nodejs/code-and-learn#58
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@sreepurnajasti @MayaLekova
doc: fix e.g., to e.g. in docs
b394a11 
PR-URL: nodejs#18369
Fixes: nodejs/code-and-learn#58
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code And Learn at NodeFest 2016
8 participants
@sreepurnajasti @vsemozhetbyt @Trott @lpinca @cjihrig @tniessen @MylesBorins @nodejs-github-bot