Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: cut down http benchmark run time #18379

Closed
wants to merge 1 commit into from
Closed

benchmark: cut down http benchmark run time #18379

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

This split the http/simple.js benchmark so the header settings can be benchmarked differently to reduce the time spent on this benchmark. IIUC other parameters do not have an impact on the results, see the OP of #10558

Also cut the default duration to 5 seconds, on the benchmark CI we have about 20k req/sec for most types of scenarios so the results from 100k reqs should be representative enough.

cc @mscdex

Refs: #18003 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. labels Jan 25, 2018
@joyeecheung
Copy link
Member Author

After #18373 lands we can see how the accuracy changes with the new parameters.

@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12772/

@joyeecheung
Copy link
Member Author

CI failures are unrelated

@joyeecheung
Copy link
Member Author

Benchmark CI: https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/107/

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 30, 2018 •
edited
Loading

For comparison, another one against a doc PR:
https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/110/
https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/111/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 31, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 1, 2018
@joyeecheung @BridgeAR
benchmark: cut down http benchmark run time
54b3a68 
PR-URL: nodejs#18379
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR
Copy link
Member

BridgeAR commented Feb 1, 2018

Landed in 54b3a68

@BridgeAR BridgeAR closed this Feb 1, 2018
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2018
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
@joyeecheung @MylesBorins
benchmark: cut down http benchmark run time
aa90b1a 
PR-URL: #18379
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@joyeecheung @MylesBorins
benchmark: cut down http benchmark run time
c14d8b9 
PR-URL: #18379
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@joyeecheung @MylesBorins
benchmark: cut down http benchmark run time
d469a06 
PR-URL: #18379
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
@MylesBorins
Copy link
Contributor

Should this be backported to v8.x-staging or v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@joyeecheung @MayaLekova
benchmark: cut down http benchmark run time
5eae9e6 
PR-URL: nodejs#18379
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@joyeecheung @BridgeAR @MylesBorins @jasnell @cjihrig @maclover7 @addaleax @nodejs-github-bot