Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x backport] 17738 and 17841 #18488

Closed
wants to merge 2 commits into from
Closed

[v9.x backport] 17738 and 17841 #18488

wants to merge 2 commits into from

Commits on Jan 31, 2018

  1. process: refactor nextTick for clarity 

    Do not share unnecessary information about nextTick state
between JS & C++, instead only track whether a nextTick
is scheduled or not.

Turn nextTickQueue into an Object instead of a class
since multiple instances are never created.

Other assorted refinements and refactoring.

PR-URL: nodejs#17738
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @apapirovski
    apapirovski committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    5257623 View commit details
    Browse the repository at this point in the history

  2. process: do not directly schedule _tickCallback in _fatalException 

    When a process encounters a _fatalException that is caught, it should
schedule execution of nextTicks but not in an arbitrary place of the
next Immediates queue. Instead, add a no-op function to the queue
that will ensure processImmediate runs, which will then ensure
that nextTicks are processed at the end.

PR-URL: nodejs#17841
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @apapirovski
    apapirovski committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    b416a7b View commit details
    Browse the repository at this point in the history