Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix unassigned deprecation codes #18492

Closed
wants to merge 2 commits into from
Closed

doc: fix unassigned deprecation codes #18492

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 1, 2018

Oopsie... Forgot to assign the deprecation code when landing #18333

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto, docs

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 1, 2018
@nodejs-github-bot nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label Feb 1, 2018
@thefourtheye
Copy link
Contributor

Just making an observation. We have DEP0089 after DEP0086.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2018
@jasnell
Copy link
Member Author

jasnell commented Feb 1, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12888/

@jasnell jasnell changed the title crypto: fix unassignd deprecation code doc: fix unassigned deprecation codes Feb 1, 2018
@jasnell jasnell mentioned this pull request Feb 1, 2018
Closed
4 tasks
jasnell added a commit that referenced this pull request Feb 1, 2018
@jasnell
crypto,doc: fix unassignd deprecation codes
2ac6658 
Missed when landing the original PRs

PR-URL: #18492
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Feb 1, 2018

Landed in 2ac6658

@jasnell jasnell closed this Feb 1, 2018
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@jasnell @MayaLekova
crypto,doc: fix unassignd deprecation codes
ced104e 
Missed when landing the original PRs

PR-URL: nodejs#18492
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jasnell @thefourtheye @cjihrig @tniessen @BridgeAR @vsemozhetbyt @MylesBorins @addaleax @nodejs-github-bot