Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add useful info to error msg and refactor #18541

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,18 @@ const assert = require('assert');

const d = domain.create();

process.on('uncaughtException', common.mustCall(function onUncaught() {
process.once('uncaughtException', common.mustCall(function onUncaught() {
assert.strictEqual(
process.domain, null,
'domains stack should be empty in uncaughtException handler');
'Domains stack should be empty in uncaughtException handler ' +
`but the value of process.domain is ${JSON.stringify(process.domain)}`);
}));

process.on('beforeExit', common.mustCall(function onBeforeExit() {
assert.strictEqual(process.domain, null,
'domains stack should be empty in beforeExit handler');
assert.strictEqual(
process.domain, null,
'Domains stack should be empty in beforeExit handler ' +
`but the value of process.domain is ${JSON.stringify(process.domain)}`);
}));

d.run(function() {
Expand Down