Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing URL types in fs promise API #18599

Closed
wants to merge 1 commit into from
Closed

doc: add missing URL types in fs promise API #18599

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Feb 6, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, fs

This seems to be slipped in #18297

Refs: #18309

cc @jasnell

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Feb 6, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 6, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/150/

@jasnell
Copy link
Member

jasnell commented Feb 6, 2018

doh! thank you! I had seen but completely forgot about that comment in the original PR.

XadillaX
XadillaX approved these changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@vsemozhetbyt
Copy link
Contributor Author

Landed in ac829f0

@vsemozhetbyt vsemozhetbyt deleted the doc-fs-promise-url branch February 6, 2018 15:33
vsemozhetbyt added a commit that referenced this pull request Feb 6, 2018
@vsemozhetbyt
doc: add missing URL types in fs promise API
ac829f0 
This seems to be slipped in #18297

PR-URL: #18599
Refs: #18309
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@vsemozhetbyt @MayaLekova
doc: add missing URL types in fs promise API
ddfb1f1 
This seems to be slipped in nodejs#18297

PR-URL: nodejs#18599
Refs: nodejs#18309
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwko iwko iwko approved these changes

@XadillaX XadillaX XadillaX approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@styfle styfle styfle approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vsemozhetbyt @jasnell @styfle @cjihrig @XadillaX @iwko @MylesBorins @nodejs-github-bot