Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: fix infinite loop #18611

Closed
wants to merge 3 commits into from
Closed

assert: fix infinite loop #18611

wants to merge 3 commits into from

Commits on Feb 7, 2018

  1. assert: fix infinite loop 

    In rare cirumstances it is possible to get a identical error diff.
In such a case the advances diffing runs into a infinite loop.
This fixes it by properly checking for extra entries.
    @BridgeAR
    BridgeAR committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    155d932 View commit details
    Browse the repository at this point in the history

  2. assert: show proper differences 

    Right now it is possible to get an AssertionError from input that has
the customInspect function set to always return the same value.

That way the error message is actually misleading because the output
is going to look the same. This fixes it by deactivating the custom
inspect function.
    @BridgeAR
    BridgeAR committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    6d0eb21 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2018

  1. fixup

    @BridgeAR
    BridgeAR committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    da63546 View commit details
    Browse the repository at this point in the history