-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix arg definition in fs #18678
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently doc building doesn't support ES-style default params in function definitions which causes an error.
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
fs
Issues and PRs related to the fs subsystem / file system.
labels
Feb 9, 2018
BridgeAR
approved these changes
Feb 9, 2018
BridgeAR
added
fast-track
PRs that do not need to wait for 48 hours to land.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Feb 9, 2018
cjihrig
approved these changes
Feb 9, 2018
evanlucas
approved these changes
Feb 9, 2018
devsnek
approved these changes
Feb 9, 2018
Thanks everyone! Landed in dbd1d1d |
apapirovski
added a commit
that referenced
this pull request
Feb 9, 2018
Currently doc building doesn't support ES-style default params in function definitions which causes an error. PR-URL: #18678 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gus Caplan <me@gus.host>
Should this be backported to |
This depends on #18297 which won't land on older branches. |
targos
added
dont-land-on-v4.x
and removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-requested-v9.x
labels
Mar 24, 2018
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Currently doc building doesn't support ES-style default params in function definitions which causes an error. PR-URL: nodejs#18678 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
fs
Issues and PRs related to the fs subsystem / file system.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently doc building doesn't support ES-style default params in
function definitions which causes a warning.
Here is the error:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
doc