Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: fix stdio sockets creation #18701

Closed
wants to merge 1 commit into from
Closed

child_process: fix stdio sockets creation #18701

wants to merge 1 commit into from

Commits on Feb 10, 2018

  1. child_process: fix stdio sockets creation 

    `readable` and `writable` properties can be passed directly to the
`net.Socket` constructor. This change also avoids an unnecessary call
to `read(0)` on the `stdin` socket. This behavior was disclosed when
trying to merge `libuv@1.19.0` and specifically this commit:
libuv/libuv@fd04939.

Refs: libuv/libuv#1655
    @santigimeno
    santigimeno committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    28e7555 View commit details
    Browse the repository at this point in the history