Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: warn against concurrent http2stream.respondWithFD #18762

Closed
wants to merge 1 commit into from
Closed

doc: warn against concurrent http2stream.respondWithFD #18762

wants to merge 1 commit into from

Commits on Feb 13, 2018

  1. doc: warn against concurrent http2stream.respondWithFD 

    Upcoming changes to move away from synchronous I/O on the main
thread will imply that using the same file descriptor to
respond on multiple HTTP/2 streams at the same time is invalid,
because at least on Windows `uv_fs_read()` is race-y.

Therefore, warn against such usage.
    @addaleax
    addaleax committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    916bb0f View commit details
    Browse the repository at this point in the history