Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add nullptr check for session in DEBUG macro #18815

Closed
wants to merge 1 commit into from
Closed

src: add nullptr check for session in DEBUG macro #18815

wants to merge 1 commit into from

Commits on Feb 16, 2018

  1. src: add nullptr check for session in DEBUG macro 

    Currenlty when configuring --debug-http2
/test/parallel/test-http2-getpackedsettings.js will segment fault:

$ out/Debug/node test/parallel/test-http2-getpackedsettings.js
Segmentation fault: 11

This is happening because the settings is created with the Environment in
PackSettings:
Http2Session::Http2Settings settings(env);
This will cause the session to be set to nullptr. When the init
function is later called the expanded DEBUG_HTTP2SESSION macro will
cause the segment fault when the session is dereferenced.

I'm not sure about what the proper solution is here as I'm not very
familiar with the http2 code yet. Creating this so that others can
provide some feedback.
    @danbev
    danbev committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    a93b901 View commit details
    Browse the repository at this point in the history