Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix abort when taking a heap snapshot #18898

Closed
wants to merge 1 commit into from
Closed

src: fix abort when taking a heap snapshot #18898

wants to merge 1 commit into from

Commits on Feb 21, 2018

  1. src: fix abort when taking a heap snapshot 

    Remove an erroneous CHECK that asserted the persistent object's internal
field pointer still pointed to a valid object.  If ClearWrap() has been
called, the field pointer equals nullptr and that is expected behavior.

Fixes: nodejs#18256
    @bnoordhuis
    bnoordhuis committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    df4d154 View commit details
    Browse the repository at this point in the history