Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: add no-half-open enforcer only if needed #18953

Closed
wants to merge 1 commit into from
Closed

stream: add no-half-open enforcer only if needed #18953

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Feb 23, 2018 •
edited
Loading

The listener does not do anything if allowHalfOpen is enabled. Add it only when allowHalfOpen is disabled.

If allowHalfOpen can be changed on the fly this PR doesn't make sense and should be closed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

stream

@lpinca
stream: add no-half-open enforcer only if needed
0af08e2 
The listener does not do anything if `allowHalfOpen` is enabled. Add
it only when `allowHalfOpen` is disabled.
@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Feb 23, 2018
@lpinca
Copy link
Member Author

lpinca commented Feb 23, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13344/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 24, 2018
mcollina
mcollina approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please also do a full CITGM run.

@lpinca
Copy link
Member Author

lpinca commented Feb 27, 2018

CIGTM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1314/

@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/13478/

@apapirovski
Copy link
Member

Landed in f2b9805

@apapirovski apapirovski closed this Mar 4, 2018
apapirovski pushed a commit that referenced this pull request Mar 4, 2018
@lpinca @apapirovski
stream: add no-half-open enforcer only if needed
f2b9805 
The listener does not do anything if `allowHalfOpen` is enabled. Add it
only when `allowHalfOpen` is disabled.

PR-URL: #18953
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca lpinca deleted the no-useless-listener branch March 4, 2018 13:31
@lpinca lpinca mentioned this pull request Mar 4, 2018
Closed
4 tasks
@MylesBorins
Copy link
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@lpinca lpinca mentioned this pull request Mar 7, 2018
Closed
lpinca added a commit to lpinca/node that referenced this pull request Mar 7, 2018
@lpinca
stream: add no-half-open enforcer only if needed
64746c7 
The listener does not do anything if `allowHalfOpen` is enabled. Add it
only when `allowHalfOpen` is disabled.

PR-URL: nodejs#18953
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 17, 2018
@lpinca @targos
stream: add no-half-open enforcer only if needed
dc30ac3 
The listener does not do anything if `allowHalfOpen` is enabled. Add it
only when `allowHalfOpen` is disabled.

PR-URL: #18953
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@lpinca @MylesBorins
stream: add no-half-open enforcer only if needed
9c0c0e6 
The listener does not do anything if `allowHalfOpen` is enabled. Add it
only when `allowHalfOpen` is disabled.

PR-URL: #18953
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

This seems to have caused a breakage. Should not be backported to LTS until a fix is found #19764

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@lpinca @MayaLekova
stream: add no-half-open enforcer only if needed
2d80dbd 
The listener does not do anything if `allowHalfOpen` is enabled. Add it
only when `allowHalfOpen` is disabled.

PR-URL: nodejs#18953
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 17, 2018

Should this be backported to 8.x now?

@mcollina
Copy link
Member

I would not backport this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@tniessen tniessen tniessen approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lpinca @apapirovski @MylesBorins @jasnell @mcollina @tniessen @BridgeAR @addaleax @nodejs-github-bot