build: fix lint-md-build dependency #18981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
joyeecheung
force-pushed
the
fix-lint-md-build
branch
from
fdda2ab
to
85c125f
Compare
devsnek
approved these changes
Feb 24, 2018
|
How to reproduce # Clean up the deps
rm -rf tools/.docmdlintstamp tools/.miscmdlintstamp tools/remark-cli/node_modules tools/remark-preset-lint-node/node_modules
# Where the package.json didn't change
git revert a29089d7c866955616c0e363843017e9b9b2a736
make lint-md # Should print the hint to run make lint-md-build
make lint-md-build # Install
make lint-md # OK
git reset --hard HEAD~1 # Now the package.json changed
make lint-md # Issue in https://github.com/nodejs/node/issues/18978 shows up
make lint-md-build # Before this patch, this does nothing. After this patch, this install again
make lint-md # Before this patch, this still errors. After this patch, this runs OK |
joyeecheung
added
the
author ready
|
@ChALkeR I think it's because |
|
^ That's true. We tried to avoid internet access. |
|
Ah, understood. @joyeecheung, @watilde, thanks for clarification! |
ChALkeR
approved these changes
Feb 26, 2018
watilde
approved these changes
Feb 26, 2018
jasnell
approved these changes
Feb 26, 2018
|
Landed in 0bff955, thanks! |
3 tasks
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Mar 5, 2018
PR-URL: nodejs#18981 Fixes: nodejs#18978 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Mar 7, 2018
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18981 Fixes: nodejs#18978 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Does this need to be backported to 8.x? |
|
This should land cleanly on v8.x if #17964 is backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18978
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build