Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: ECDH convertKey to convert public keys between different formats #19080

Closed
wants to merge 8 commits into from
Closed

crypto: ECDH convertKey to convert public keys between different formats #19080

wants to merge 8 commits into from
+275 −45

Commits on Mar 10, 2018

  1. crypto: ECDH function to convert public keys 

    ECDH.convertKey is used to convert public keys
between different formats.

Fixes: nodejs#18977
    @wuweiweiwu
    wuweiweiwu committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    41a17db View commit details
    Browse the repository at this point in the history

  2. crypto: refactoring shared code 

    refactored ECDH::BufferToPoint and
key formatting
    @wuweiweiwu
    wuweiweiwu committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    9ded80c View commit details
    Browse the repository at this point in the history

  3. test: adding tests for ECDH#convertKey 

    Adding tests to verify that convertkey
correctly converts ECDH keys to different
formats
    @wuweiweiwu
    wuweiweiwu committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    e876f36 View commit details
    Browse the repository at this point in the history

  4. doc: adding docs for ECDH#convertKey 

    Adding docs and usage examples.
    @wuweiweiwu
    wuweiweiwu committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    810cb37 View commit details
    Browse the repository at this point in the history

  5. crypto: clean up pointers on failure 

    Using std::shared_ptr to clean up pointers.
Formatting changes. Refactoring encode function.
    @wuweiweiwu
    wuweiweiwu committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    17f1703 View commit details
    Browse the repository at this point in the history

  6. crypto: minor fixes 

    Using const over var. Destructuring notation.
Updated function signature.
    @wuweiweiwu
    wuweiweiwu committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    d5f07d9 View commit details
    Browse the repository at this point in the history

  7. crypto: input typechecking 

    Handle input typechecking in JavaScript using
errors. Minor fixes and updated tests
    @wuweiweiwu
    wuweiweiwu committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    c201c26 View commit details
    Browse the repository at this point in the history

  8. crypto: using the updated errors 

    Using the new error throwing mechanism.
    @wuweiweiwu
    wuweiweiwu committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    541a651 View commit details
    Browse the repository at this point in the history