Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v8.x backport) crypto: reuse variable instead of reevaluation #19114

Closed

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Mar 4, 2018

Backport of #17735 to v8.x.

PR-URL: nodejs#17735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. v8.x labels Mar 4, 2018
@gibfahn gibfahn self-assigned this Mar 4, 2018
@gibfahn
Copy link
Member

gibfahn commented Mar 20, 2018

@MylesBorins
Copy link
Contributor

potentially related failure in debian 8 https://ci.nodejs.org/job/node-test-commit-linux/17205/nodes=debian8-x86/console

09:37:16 not ok 1028 parallel/test-https-client-resume
09:37:16   ---
09:37:16   duration_ms: 0.512
09:37:16   severity: fail
09:37:16   stack: |-

@tniessen
Copy link
Member Author

This PR should not affect TLS tests. I started two more CIs, the first failed parallel/test-tls-ca-concat and the second passed without problems. There might be some flakiness with TLS tests on this branch, but it is unlikely to be caused by this change.

MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
Backport-PR-URL: #19114
PR-URL: #17735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins
Copy link
Contributor

Thanks for the heads up

landed in b43a59c

MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
Backport-PR-URL: #19114
PR-URL: #17735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
Backport-PR-URL: #19114
PR-URL: #17735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants