Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove subsystem from pull request template #19125

Closed
wants to merge 1 commit into from

Commits on Mar 4, 2018

  1. doc: remove subsystem from pull request template

    Remove request that user provide a list of subsystems in the pull
    request template.
    
    * We already ask them to put the subsystems in the first line of the
      commit message.
    * The subsystem is usually easy to determine.
    * We have a bot that applies subsystem labels on new PRs and it seems to
      do a rather good job. Tools over rules. Let the bot do it.
    * The fewer unnecessary things we ask for in the template, the lower the
      barrier to entry.
    * Anecdotal, but I have never found it useful to have the person
      submitting the PR list out subsystems in the pull request post.
    Trott committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    dfa0747 View commit details
    Browse the repository at this point in the history