Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] node internals' postmortem metadata (#14901, #18530, #18653) #19176

Closed
wants to merge 3 commits into from
Closed

[v8.x backport] node internals' postmortem metadata (#14901, #18530, #18653) #19176

wants to merge 3 commits into from

Commits on Mar 6, 2018

  1. src, test: node internals' postmortem metadata 

    Before these changes, only V8 added postmortem metadata to Node's
binary, limiting the possibilities for debugger's developers to add some
features that rely on investigating Node's internal structures.

These changes are first steps towards empowering debug tools to
navigate Node's internal structures. One example of what can be
achieved with this is shown at nodejs/llnode#122 (a command which prints
information about handles and requests on the queue for a core dump
file). Node postmortem metadata are prefixed with nodedbg_.

This also adds tests to validate if all postmortem metadata are
calculated correctly, plus some documentation on what is postmortem
metadata and a few care to be taken to avoid breaking it.

Ref: nodejs/llnode#122
Ref: nodejs/post-mortem#46

PR-URL: nodejs#14901
Refs: nodejs/post-mortem#46
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Matheus Marchini authored and Matheus Marchini committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    77eb8e2 View commit details
    Browse the repository at this point in the history

  2. test: fix cctest -Wunused-variable warning 

    PR-URL: nodejs#18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    @bnoordhuis
    bnoordhuis authored and Matheus Marchini committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    cd00e23 View commit details
    Browse the repository at this point in the history

  3. src: do not redefine private for GenDebugSymbols 

    Redefining private breaks any private inheritance in the
included files. We can simply declare GenDebugSymbols()
as friends in related classes to gain the access that we need.

PR-URL: nodejs#18653
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @joyeecheung
    joyeecheung authored and Matheus Marchini committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    0fce524 View commit details
    Browse the repository at this point in the history