Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move Environment ctor/dtor into env.cc #19202

Closed
wants to merge 1 commit into from
Closed

src: move Environment ctor/dtor into env.cc #19202

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 7, 2018

Splitting out from #18936:

This makes it easier to use methods from other headers
in the constructor and destructor.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes (presumably)
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 7, 2018
@addaleax
Copy link
Member Author

addaleax commented Mar 7, 2018

CI: https://ci.nodejs.org/job/node-test-commit/16762/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 7, 2018
@addaleax addaleax force-pushed the env-cdtor-envcc branch 3 times, most recently from 9ab1d5a to 2260798 Compare March 7, 2018 19:46
@addaleax
src: move Environment ctor/dtor into env.cc
68c12a5 
This makes it easier to use methods from other headers
in the constructor and destructor.
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 11, 2018
@addaleax @BridgeAR
src: move Environment ctor/dtor into env.cc
e0bd2f3 
This makes it easier to use methods from other headers
in the constructor and destructor.

PR-URL: nodejs#19202
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR
Copy link
Member

Landed in e0bd2f3 🎉

@BridgeAR BridgeAR closed this Mar 11, 2018
@MylesBorins
Copy link
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@MylesBorins MylesBorins mentioned this pull request Mar 20, 2018
Closed
3 tasks
@addaleax addaleax deleted the env-cdtor-envcc branch April 14, 2018 16:18
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 14, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@addaleax @MayaLekova
src: move Environment ctor/dtor into env.cc
f161531 
This makes it easier to use methods from other headers
in the constructor and destructor.

PR-URL: nodejs#19202
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit to addaleax/node that referenced this pull request Jun 30, 2018
@addaleax
src: move Environment ctor/dtor into env.cc
9977a76 
This makes it easier to use methods from other headers
in the constructor and destructor.

PR-URL: nodejs#19202
@addaleax addaleax mentioned this pull request Jun 30, 2018
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Jul 13, 2018
@addaleax @MylesBorins
src: move Environment ctor/dtor into env.cc
1aa1ff4 
This makes it easier to use methods from other headers
in the constructor and destructor.

Backport-PR-URL: #21599
PR-URL: #19202
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@addaleax @rvagg
src: move Environment ctor/dtor into env.cc
2ee4bb7 
This makes it easier to use methods from other headers
in the constructor and destructor.

Backport-PR-URL: #21599
PR-URL: #19202
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@addaleax @BridgeAR @MylesBorins @danbev @jasnell @targos @cjihrig @joyeecheung @nodejs-github-bot