Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: destroy() stream, upon errnoException #19389

Closed
wants to merge 1 commit into from
Closed

http2: destroy() stream, upon errnoException #19389

wants to merge 1 commit into from

Conversation

SirR4T
Copy link
Contributor

@SirR4T SirR4T commented Mar 16, 2018

First steps towards #19060

Attempting to move lib/net and lib/http2/core towards similar API, for all work of reading and writing from underlying stream.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Mar 16, 2018
addaleax
addaleax approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mcollina
mcollina approved these changes Mar 17, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 19, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/17005/

@jasnell
Copy link
Member

jasnell commented Mar 20, 2018

The failures in CI are related.

@SirR4T
Copy link
Contributor Author

SirR4T commented Mar 20, 2018

@addaleax / @jasnell : did i break something here? How do i fix it?

@addaleax
Copy link
Member

I can’t see anything in the CI failures that strikes out as something related.

New CI: https://ci.nodejs.org/job/node-test-commit/17118/

@addaleax addaleax mentioned this pull request Mar 23, 2018
Closed
4 tasks
@addaleax
Copy link
Member

Landed in 84afd6e 🎉

@addaleax addaleax closed this Mar 23, 2018
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 23, 2018
addaleax pushed a commit that referenced this pull request Mar 23, 2018
@SirR4T @addaleax
http2: destroy() stream, upon errnoException
84afd6e 
First steps towards #19060

PR-URL: #19389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Apr 2, 2018
@SirR4T @targos
http2: destroy() stream, upon errnoException
7b850a7 
First steps towards #19060

PR-URL: #19389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos mentioned this pull request Apr 4, 2018
Merged
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@SirR4T @kjin
http2: destroy() stream, upon errnoException
d932237 
First steps towards nodejs#19060

PR-URL: nodejs#19389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@SirR4T @MylesBorins
http2: destroy() stream, upon errnoException
519b063 
First steps towards #19060

Backport-PR-URL: #20456
PR-URL: #19389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@SirR4T @MylesBorins
http2: destroy() stream, upon errnoException
58a7fd0 
First steps towards #19060

Backport-PR-URL: #20456
PR-URL: #19389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@SirR4T @MylesBorins
http2: destroy() stream, upon errnoException
eddf3a6 
First steps towards #19060

Backport-PR-URL: #20456
PR-URL: #19389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SirR4T @addaleax @jasnell @mcollina @nodejs-github-bot