Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve tty.getColorDepth coverage #19446

Closed
wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Mar 19, 2018

The tty.getColorDepth function has only a very basic coverage. This almost fully covers that function (there are some parts that can not really be tested).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Mar 19, 2018
@BridgeAR
Copy link
Member Author

@lpinca
Copy link
Member

lpinca commented Mar 19, 2018

  • make -j4 test (UNIX), or vcbuild test (Windows) passes

Lies 😉

@BridgeAR
Copy link
Member Author

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 20, 2018
}

process.env.NODE_DISABLE_COLORS = NODE_DISABLE_COLORS;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails when being run with NODE_PENDING_DEPRECATION=1, because NODE_DISABLE_COLORS can be undefined at this point.

I guess you could just drop this line? Setting an environment variable at the end of the script shouldn’t make a difference anyway, I think…

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 23, 2018
@BridgeAR
Copy link
Member Author

Comment addressed. PTAL.

CI https://ci.nodejs.org/job/node-test-pull-request/13845/

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 27, 2018
PR-URL: nodejs#19446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@BridgeAR
Copy link
Member Author

Landed in ce2ed58

@BridgeAR BridgeAR closed this Mar 27, 2018
@targos
Copy link
Member

targos commented Apr 2, 2018

Should only be backported to v9.x-staging if #18800 is.

Edit: wrong reference

BridgeAR added a commit to BridgeAR/node that referenced this pull request May 1, 2018
PR-URL: nodejs#19446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@BridgeAR BridgeAR deleted the increase-test-coverage branch April 1, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants