Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add link & simplify data event (net.Socket) #19487

Closed
wants to merge 1 commit into from
Closed

doc: add link & simplify data event (net.Socket) #19487

wants to merge 1 commit into from

Conversation

boneskull
Copy link
Contributor

@boneskull boneskull commented Mar 20, 2018 •
edited
Loading

This adds a more specific link from the docs for net.Socket's data event to socket.setEncoding(), which in turn links to the readable stream docs for more info. It removes the link directly to the readable stream docs.

It also fixes a misnamed link (stream.setEncoding when should be readable.setEncoding)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@boneskull
doc: add link & simplify data event (net.Socket)
503d7ac 
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Mar 20, 2018
@trivikr
Copy link
Member

trivikr commented Mar 25, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/327/

trivikr pushed a commit to trivikr/node that referenced this pull request Mar 25, 2018
@boneskull @trivikr
doc: add link & simplify data event (net.Socket)
df0a37a 
PR-URL: nodejs#19487
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@trivikr
Copy link
Member

trivikr commented Mar 25, 2018

Landed in df0a37a

@trivikr trivikr closed this Mar 25, 2018
targos pushed a commit that referenced this pull request Mar 27, 2018
@boneskull @targos
doc: add link & simplify data event (net.Socket)
d47e5d0 
PR-URL: #19487
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boneskull @trivikr @jasnell @nodejs-github-bot