doc: fix grammar in tls and timers #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace 'a' with 'an' where appropriate
|
LGTM |
|
@cjihrig Are you going to land it? |
|
@bnoordhuis sure thing. This targets the 0.10 branch. Is io going to have a 0.10, or should this land on 0.12? |
|
Oh, so it does. I don't think we'll be doing v0.10 releases, it should go into v0.12. |
|
@gdi2290 would you mind signing the commit using your real name? |
|
Actually, since we're not landing on the v0.10 branch, I think this can just be closed. The same changes landed on v0.12 in 9bca8a0. |
jasongin
added a commit
to jasongin/nodejs
that referenced
this pull request
Mar 23, 2017
- Check the type before casting to string when creating error objects. - Return an error when napi_typeof does not find any valid type.
boingoing
pushed a commit
to boingoing/node
that referenced
this pull request
Apr 6, 2017
- Check the type before casting to string when creating error objects. - Return an error when napi_typeof does not find any valid type.
This was referenced Dec 28, 2020
Open
This was referenced Feb 11, 2024
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace 'a' with 'an' where appropriate