Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "readline: allow tabs in input" #1961

Closed
wants to merge 1 commit into from
Closed

Revert "readline: allow tabs in input" #1961

wants to merge 1 commit into from

Conversation

Fishrock123
Copy link
Contributor

This reverts commit 4b3d493.

Result of some quick discussion with @Trott and @chrisdickinson at nodeconf, it appears this should be semver-major for safety.

cc @rvagg / @brendanashworth, this should land before 2.3.0 releases. (ASAP)

@Fishrock123 Fishrock123 added the readline Issues and PRs related to the built-in readline module. label Jun 12, 2015
@Fishrock123 Fishrock123 mentioned this pull request Jun 12, 2015
Closed
@Fishrock123
Copy link
Contributor Author

Also, I will be landing this in next, assuming that LGT-Everyone.

@cjihrig
Copy link
Contributor

cjihrig commented Jun 12, 2015

LGTM

@yosuke-furukawa
Copy link
Member

LGTM2

Fishrock123 added a commit that referenced this pull request Jun 12, 2015
@Fishrock123
Revert "readline: allow tabs in input"
d9e2502 
This reverts commit 4b3d493.

PR-URL: #1961
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
@Fishrock123
Copy link
Contributor Author

Thanks, merged in d9e2502

@Fishrock123
Copy link
Contributor Author

(Will land the original commit back into next momentarily.)

@Fishrock123 Fishrock123 mentioned this pull request Jun 12, 2015
Closed
@Fishrock123
Copy link
Contributor Author

Re-landed on next at 2ebc77d

@Fishrock123 Fishrock123 reopened this Jun 12, 2015
@Trott
Copy link
Member

Trott commented Jun 20, 2015

@Fishrock123 Th re-landing of the change appears to have been clobbered at some point in next. Looking at https://github.com/nodejs/io.js/blob/next/lib/readline.js right now, all the code that was reverted on master in this change appears to be the same there as well. Am I looking at the wrong thing? If not, do you know what happened?

@rvagg rvagg mentioned this pull request Jul 30, 2015
Closed
Fishrock123 added a commit that referenced this pull request Aug 1, 2015
@Fishrock123 @rvagg
Revert "readline: allow tabs in input"
83167ee 
This reverts commit 4b3d493.

PR-URL: #1961
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
This was referenced Jun 22, 2023
Open
Open
Open
Open
This was referenced Jul 7, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fishrock123 @cjihrig @yosuke-furukawa @Trott