Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve zero-fill-buffers text #19623

Closed
wants to merge 1 commit into from
Closed

doc: improve zero-fill-buffers text #19623

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 26, 2018

  • improve text for easier comprehension
  • clarify that performance impact is negative
  • remove superfluous "either" (should only be used when there are 2
    options anyway)
  • remove superfluous italics
  • line wrap at 80 chars
Checklist

@Trott
doc: improve zero-fill-buffers text
a3efcfb 
* improve text for easier comprehension
* clarify that performance impact is *negative*
* remove superfluous "either" (should only be used when there are 2
  options anyway)
* remove superfluous italics
* line wrap at 80 chars
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Mar 26, 2018
@Trott
Copy link
Member Author

Trott commented Mar 26, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/345/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 26, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 26, 2018
@trivikr
Copy link
Member

trivikr commented Mar 27, 2018

Previous CI was aborted.
New CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/347/

@trivikr
Copy link
Member

trivikr commented Mar 27, 2018

Landed in 8eca6b8

@trivikr trivikr closed this Mar 27, 2018
trivikr pushed a commit that referenced this pull request Mar 27, 2018
@Trott @trivikr
doc: improve zero-fill-buffers text
8eca6b8 
* improve text for easier comprehension
* clarify that performance impact is *negative*
* remove superfluous "either" (should only be used when there are 2
  options anyway)
* remove superfluous italics
* line wrap at 80 chars

PR-URL: #19623
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
targos pushed a commit that referenced this pull request Apr 2, 2018
@Trott @targos
doc: improve zero-fill-buffers text
7555dee 
* improve text for easier comprehension
* clarify that performance impact is *negative*
* remove superfluous "either" (should only be used when there are 2
  options anyway)
* remove superfluous italics
* line wrap at 80 chars

PR-URL: #19623
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@targos targos mentioned this pull request Apr 4, 2018
Merged
@Trott Trott deleted the zero-fill-buffers branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChALkeR ChALkeR ChALkeR approved these changes

@addaleax addaleax addaleax approved these changes

@Leko Leko Leko approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @trivikr @ChALkeR @addaleax @Leko @TimothyGu @cjihrig @vsemozhetbyt @nodejs-github-bot